Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update retry configuration for Azure SDKs service builder in Spring tier #25104

Merged
merged 15 commits into from
Nov 4, 2021
Merged

Update retry configuration for Azure SDKs service builder in Spring tier #25104

merged 15 commits into from
Nov 4, 2021

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Oct 29, 2021 •
edited
Loading

Fixes #24754

Changelog:

  • Update retry configuration for Azure service client builder:
    • HTTP-based Service builder retry
      • HTTP retry
      • Http Storage retry
    • AMQP-based service builder retry
    • Cosmos Service builder retry
  • Add service enabled control in isKeyVaultPropertySourceEnabled method

@ghost ghost added the azure-spring All azure-spring related issues label Oct 29, 2021
@moarychan moarychan linked an issue Oct 29, 2021 that may be closed by this pull request
Support configure retry in spring cloud azure 4.0 #24754
Closed
@moarychan moarychan marked this pull request as ready for review November 1, 2021 06:11
Moary Chen added 2 commits November 2, 2021 11:48
saragluna
saragluna requested changes Nov 2, 2021
View reviewed changes
...nfigure/src/main/java/com/azure/spring/cloud/autoconfigure/cosmos/AzureCosmosProperties.java Outdated Show resolved Hide resolved
...re-core/src/main/java/com/azure/spring/core/converter/AzureRequestRetryOptionsConverter.java Outdated Show resolved Hide resolved
...-core/src/main/java/com/azure/spring/core/factory/AbstractAzureHttpClientBuilderFactory.java Show resolved Hide resolved
...oud-azure-core/src/main/java/com/azure/spring/core/properties/retry/HttpRetryProperties.java Show resolved Hide resolved
...-azure-core/src/main/java/com/azure/spring/core/properties/retry/StorageRetryProperties.java Outdated Show resolved Hide resolved
...n/java/com/azure/spring/service/storage/common/AbstractAzureStorageClientBuilderFactory.java Outdated Show resolved Hide resolved
@saragluna saragluna self-assigned this Nov 3, 2021
@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna
Copy link
Member

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna saragluna merged commit ccfc66d into Azure:feature/azure-spring-cloud-4.0 Nov 4, 2021
@saragluna saragluna mentioned this pull request Nov 4, 2021
Closed
@moarychan moarychan deleted the feature-update/azure-service-retry-configuration branch November 17, 2021 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@zhichengliu12581 zhichengliu12581 Awaiting requested review from zhichengliu12581

Assignees

@saragluna saragluna

Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support configure retry in spring cloud azure 4.0
2 participants
@moarychan @saragluna